dynamic-dynamodb icon indicating copy to clipboard operation
dynamic-dynamodb copied to clipboard

Circuit breaker url checked for every dynamo table being monitored?

Open ricardclau opened this issue 10 years ago • 2 comments

Hi

I am seeing that the circuit breaker url is checked as many times as the # of tables being monitored. Being it a "global" setting does it make sense to do it that way? Perhaps I am missing something?

Not that it is very high CPU consuming or anything but I was just curious about the motivation for doing it VS just asking once for every check interval

Info very much appreciated!

ricardclau avatar Mar 02 '15 14:03 ricardclau

Hey,

Yeah, well. I agree somehow. It's slightly unnecessary to do it once before each check (although the circuit breaker might be open between check 1 and 2 for example).

I would actually prefer to have it done before each table check, but configurable on a per table basis. It might be radically different checks for Table1 and Table2 for example.

sebdah avatar Mar 03 '15 08:03 sebdah

Yeah, I agree with your point as well

And you are totally right about the fact that there could be completely different checks between tables. Dynamo is a service tight to an AWS account, which may in fact mean several completely different applications

I will try to have a look later this week and perhaps contribute with a PR

Thanks!

ricardclau avatar Mar 03 '15 09:03 ricardclau