kiss3d icon indicating copy to clipboard operation
kiss3d copied to clipboard

Support u32 face index

Open virtualritz opened this issue 4 years ago • 8 comments

Mesh::faces is currently Vec<Point3<u16>>.

It would be great to make this u32 to allow meshes with >64k points. Either always or as a variant, as e.g. in bevy's IndexFormat.

virtualritz avatar Dec 26 '20 16:12 virtualritz

I'd be willing to attempt to implement this and submit a PR if it would be accepted.

brightly-salty avatar Jan 07 '21 03:01 brightly-salty

Hi! The problem with meshes with u32 indices is that they are not compatible with WebGL 1.0. So we can't only allow u32. Using a variant would be an accepted solution, yes.

sebcrozet avatar Jan 07 '21 09:01 sebcrozet

Is that really a problem? I mean do you know what % of your crate's users rely on WebGl 1.0 compatibility?

virtualritz avatar Jan 07 '21 15:01 virtualritz

Is that really a problem? I mean do you know what % of your crate's users rely on WebGl 1.0 compatibility?

I don't know the percentage but I am one of these users. WebGl 2.0 isn't well supported on Safari without enabling some experimental features: https://caniuse.com/webgl2

sebcrozet avatar Jan 07 '21 15:01 sebcrozet

Any update on this?

virtualritz avatar May 27 '21 11:05 virtualritz

WebGL 2 is now supported in Safari, it seems.

virtualritz avatar Jun 07 '21 21:06 virtualritz

Bump this, I cannot load certain large meshes due to this. Any updates/workarounds?

LeandroMarceddu avatar May 15 '22 07:05 LeandroMarceddu

It's been 11 months now that Safari 15 with WebGl 2 support was released. Looking at caniuse.com it seems only fringe browsers do not support this version.

virtualritz avatar Aug 19 '22 09:08 virtualritz