instant icon indicating copy to clipboard operation
instant copied to clipboard

This crates needs to be archived, and should redirect to web-time

Open erwanvivien opened this issue 1 year ago • 4 comments

  • Unmaintained
    • Bug in implementation not fixed for almost a year https://github.com/sebcrozet/instant/issues/49
  • Is slow to use Performance https://github.com/sebcrozet/instant/issues/21
  • More here:
    • https://github.com/rust-cv/cv/pull/75#issuecomment-1645191608

Alternative is to change to web-time

erwanvivien avatar Aug 28 '23 16:08 erwanvivien

@sebcrozet do you think think it might make sense to put out an informational advisory to make it clear this crate is no longer being maintained? Would be nice to inform downstream users.

djc avatar Feb 10 '24 21:02 djc

@djc Given the extensive use of this crate (per stats on crates.io) and the lack of maintenance, seems prudent to submit this crate to Rustsec's database as unmaintained (certainly meets the Unmaintained Crate policy timeline thresholds).

@sebcrozet Please let us know if you plan to continue maintenance! Will likely submit this in the next week or so.

TheMartianObserver avatar Mar 03 '24 06:03 TheMartianObserver

@TheMartianObserver I don’t expect to have much time maintaining this crate unfortunately. So I am happy to provide maintenance access to a volunteer. I am otherwise OK with marking this as unmaintained.

sebcrozet avatar Mar 03 '24 10:03 sebcrozet

@TheMartianObserver I don’t expect to have much time maintaining this crate unfortunately. So I am happy to provide maintenance access to a volunteer. I am otherwise OK with marking this as unmaintained.

Thank you for the response, and completely understand about the time commitment.

Unfortunately, given that time-web exists with effectively the same API and a number of other crates have already shifted to that, I think it's probably best to archive this repo and mark it as unmaintained.

TheMartianObserver avatar Mar 04 '24 02:03 TheMartianObserver

The main problem with web_time is that is does not support wasm32-unknown-emscripten target. Any known solutions ?

Captainfl4me avatar May 07 '24 15:05 Captainfl4me

I marked the crate as unmaintained on the readme and cargo badge.

sebcrozet avatar May 17 '24 19:05 sebcrozet

Thanks for the good work seb 🙏

erwanvivien avatar May 17 '24 22:05 erwanvivien

The main problem with web_time is that is does not support wasm32-unknown-emscripten target. Any known solutions ?

AFAIK wasm32-unknown-emscripten doesn't need a polyfill, Std should work just fine. Therefore web-time, which in this case just re-exports Std, should work as well.

EDIT: Nope, I was wrong, wasm32-unknown-emscriptens Std implementation of time panics as well. I'm looking into if this in scope for web-time.

EDIT 2: My bad, I forgot that Emscripten falls under cfg(unix). Just tried it as well, Std works just fine, therefore web-time works as well.

daxpedda avatar May 21 '24 10:05 daxpedda

I've submitted an informational advisory to the database in https://github.com/rustsec/advisory-db/pull/2056.

Another thing to do would be to add something like #![deprecated = "use the `web-time` crate instead"], that'd probably be more successful in getting people migrated.

A final option would be to release v0.2 as just pub use web_time::*;, that'd at least avoid people having updated dependencies.

These are not mutually exclusive.

madsmtm avatar Sep 01 '24 13:09 madsmtm