php-microsoft-teams-connector icon indicating copy to clipboard operation
php-microsoft-teams-connector copied to clipboard

fix: correct type of verson in CustomAdaptiveCard

Open tinect opened this issue 1 year ago • 3 comments

Version must be a string otherwise, M$ will answer with an exception. Additionally, the new workflow will result with empty string instead of "1".

tinect avatar Jul 08 '24 08:07 tinect

Thanks @tinect for the PR, it will try to review it as soon as I can

sebbmeyer avatar Jul 10 '24 09:07 sebbmeyer

@sebbmeyer I can confirm this is needed and PR is correct. Eventually might be a good idea to change all versions around the code to strings like it's done in https://github.com/sebbmeyer/php-microsoft-teams-connector/blob/master/src/Cards/Adaptive/BaseAdaptiveCard.php#L23

janmyszkier avatar Nov 14 '24 07:11 janmyszkier

@janmyszkier thanks for checking the PR. I try check every open PR on the weekend and merge it

sebbmeyer avatar Nov 21 '24 22:11 sebbmeyer