php-microsoft-teams-connector icon indicating copy to clipboard operation
php-microsoft-teams-connector copied to clipboard

Return has changed

Open tebulrich opened this issue 2 years ago • 3 comments

in vendor/sebbmeyer/php-microsoft-teams-connector/src/TeamsConnector.php - Row 45, it checks for if ($result !== "1")

however, the return has changed and so you get something like this:

{"version":"1.1","content":{"headers":[{"key":"Content-Type","value":["text/plain; charset=utf-8"]}]},"statusCode":200,"reasonPhrase":"OK","headers":[],"trailingHeaders":[],"requestMessage":null,"isSuccessStatusCode":true}

therefor, this package will always throw an exception

tebulrich avatar Jan 13 '23 21:01 tebulrich

@tebeso feel free to submit a PR and will take a look at it

sebbmeyer avatar Jan 14 '23 10:01 sebbmeyer

will do so on monday

tebulrich avatar Jan 14 '23 11:01 tebulrich

https://github.com/sebbmeyer/php-microsoft-teams-connector/pull/25

tebulrich avatar Jan 17 '23 13:01 tebulrich