sebbader-sap

Results 50 comments of sebbader-sap

> So to create the release folder you need to execute the following commands and then push again: Just did so

> An other issue that will come up is the "Prevent Changes to Release Files" check that is executed, since this one will fail if files are modified in the...

I think so, too. @jimmarino as you have opened the issue, please have a look.

Great observations, I already prepared a fix for the first and third one. `RightOperand` is not defined on purpose, as it can appear in many ways in JSON. If you...

Let's use #236 to derive a solution.

> the key in this case is #/definitions/Offer instead of Offer. I see, this is of course a correct finding but already merged, see https://github.com/International-Data-Spaces-Association/ids-specification/blob/36960607a67793e3fc5089655102ac6d5b9b5445/negotiation/message/schema/contract-schema.json#L105

We need to continue this discussion as soon as the Eclipse Project has been established. As the 2024-1 release in this repo is nearly done, any further corrections / extensions...

@schoenenberg the problem is the current situation between the work inside IDSA (past) and Eclipse (future). Therefore, the general activity here is quite low. It will get better as soon...

Adding another yet one: - [x] Context in line 58 is missing a comma

> AbstractPolicyRule does not contain odrl:target: The clause with `not(required)` didn't really work out as intended, therefore, this line has been deleted.