Sebastian Thomas

Results 24 comments of Sebastian Thomas

Python formatting is wrong: https://github.com/magma/magma/runs/7672630528?check_suite_focus=true

I think here it would be good to do an integration test run on your fork before the merge.

This might need a rebase, I think the broken dp integ test is fixed on master.

Yes, they're green for me too. Don't these tests run in the CI?

> warning This will also likely break the builds for all old branches (if they are not currently broken). > > Should we add some documentation somewhere to make this...

There is now an integration test workflow running against the deployed debian packages in the CI on master.

Tasks - [x] Reproduce and fix the bug - The problem seems to be how the contexts of the subscriber data are handled on the subpage, i.e. that only the...

Did you test the case of a production setup? I guess the variable is not set and then it just works and it's also not set in the containers? Edit:...

Can this be closed with the new base image or is there still more to be removed?

A lot of overlap with #13684. I'll move most of the points there, and keep this task for the CI setup.