esprima-dotnet icon indicating copy to clipboard operation
esprima-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon sebastienros

Class parsing improvements

Open lahma opened this issue 2 years ago • 4 comments

Trying to fix as many class parsing related problems as possible, without introducing new failing test cases.

lahma avatar May 28 '22 08:05 lahma

@lahma are these changes I should port back to esprima-next?

jogibear9988 avatar Jun 04 '22 05:06 jogibear9988

@jogibear9988 I believe that is the case when I get this finished. My goal is to get all outstanding class-parsing problems sorted and I've already found some interesting bugs and construct problems. The end result might be this is going to be relatively big PR (if I get it finished!).

lahma avatar Jun 04 '22 07:06 lahma

Thanks for doing the rebase, I need to go trough this again with some thought at some point....

lahma avatar Sep 07 '22 15:09 lahma

No problem. I think it might be the best to finish the fixes that this PR currently contains without including more and merge it. Then to address parser issues not with megaPRs but with smaller ones focusing on a single bug/missing feature/etc so we have less merge conflicts or at least they would be more easy to handle.

adams85 avatar Sep 07 '22 22:09 adams85

I'd also like if thepull requests are small, so it's easier for me to see if I need the change also on esprima-next. I woule be happy if the projects could stay in sync a little bit. So we should check after this is merged to include my fixes I mentioned here: https://github.com/sebastienros/esprima-dotnet/issues/330#issuecomment-1239963406

jogibear9988 avatar Oct 03 '22 06:10 jogibear9988

Closing as obsolete.

lahma avatar Dec 31 '22 12:12 lahma