Sébastien Levert

Results 242 comments of Sébastien Levert

Thank you so much for this feedback @cwdata! If we were to work on something like you suggest, how would you feel if the web components were loading React but...

We are currently investigating options in this area. We haven't identified a golden path, but are really working hard to help you develop in every framework MGT already works today!

I think we should add the premium APIs query string parameter only on APIs that support it. This will limit the scope and reduce questions (and confusion).

As we released v4 a couple weeks ago, can you try with using MGT v4 and see if you get the same error? Thanks!

This would be an unsupported scenario for now.

I like this option. Thanks for suggesting @MattBillFred! Do you want to send a PR with the change? Thanks!

Ca we identify a more sustainable solution? As these classes are dynamically generated, it would be great to have a way to avoid this.

I was able to reproduce with the same experience using 3.1.3. Would you be willing to help us fix this issue by submitting a PR? Thanks!

This PR would only fix the `loginInitiated`. This line is not touched but I don't understand why it's not reached though... https://github.com/microsoftgraph/microsoft-graph-toolkit/blob/fffb12b9cf06041b37bc857854942ec44a2a01f7/packages/mgt-components/src/components/mgt-login/mgt-login.ts#L300

My mistake, Copy/Past failures. https://github.com/microsoftgraph/microsoft-graph-toolkit/blob/fffb12b9cf06041b37bc857854942ec44a2a01f7/packages/mgt-components/src/components/mgt-login/mgt-login.ts#L254 The same happens here. It should get triggered (we don't have the same weird logic we had with `loginInitiated`.