Sebastian Stammler

Results 61 issues of Sebastian Stammler

In https://github.com/ethereum-optimism/optimism/pull/9117, installation of a new tool `eth2-testnet-genesis` was added to the Circle CI config. It references the version from the `versions.json` file. However, other software that is installed in...

T-node

`nilaway` detects false positives when `errors.Join` is used together with errors that are guaranteed to not be `nil`, like `errors.Join(errors.New("an error"))`. `nilaway` could have the rule: if any of the...

enhancement

- contracts: Add AaveMock for testnets - contracts: Add OffsetHelperMock for testnets - contracts: Add ERC20AutoMinter and SFETestUSD for testnets - contracts: Add missing license headers - contracts: Add package...

Donation as `stake` to `beneficiary`. New `Donated` event.

"Please update the following actions to use Node.js 16: `actions/checkout`, `BetaHuhn/deploy-to-vercel-action`, `actions/checkout`"

It would be nice to use the shared solidity revert strings from `packages/contracts/shared/revertReasons.ts` in Solidity source files instead of having duplicate definitions. One solution could be to use the [`solpp`](https://github.com/merklejerk/solpp)...

Since 0.8.4 Solidity supports [custom errors](https://blog.soliditylang.org/2021/04/21/custom-errors/). We might consider using them. First need to check how well it is supported in our tooling etc though. E.g. error catching is not...

In https://github.com/yieldgate/yieldgate/pull/52 commit https://github.com/yieldgate/yieldgate/pull/52/commits/89c1eae93787d9f78d5f2f6fd61c7814d6a8dd50 adds coverall reporting, but it seems to be broken right now. Codecov works. But Coveralls apparently has better branch coverage reporting for Solidity, so it might...

Over the past couple weeks we discussed many extensions that we want the smart contracts to cover for our mainnet deployment. I'll collect them here, referencing sub-issues where applicable. *...