kirby3-commentions
kirby3-commentions copied to clipboard
incompatibility with translations plugin
There seems to be a incompatibility with daandelange's kirby3 translations plugin.
When I install the translations plugin, commentions stops working.
It's a bit weird, because all translated strings stop showing (see screenshot) and the plugin stops working, but I don't get an error. So for me it's kind of hard to spot where the problem arises.
I know that translations plugin is also in beta – just wanted to share my findings, in case anyone else comes across the same issue.
To be investigated: this might be related to our workaround to the issue that hardcoded translations in plugins cannot (at least could not back in 2020; need to check if this is still the case?) be overridden by user-defined translation strings; see https://forum.getkirby.com/t/override-translations-in-plugins/17997 (applied in our code here).
Left a note in the k3-translations plugin's issue as well, to keep the author informed.
@hariom147 I hope you don't mind me pinging you here in a slightly off-topic manner, but I'd like to draw your attention to my update that I am no longer able to maintain the Commentions plugin in the future → details here.
Dear @sebastiangreger, thank you for reaching out.
Aft having the issue the translations plugin and looking into your code, I did realize how complex the plugin is. And I noticed, that commits were rather sparse, so I already guessed that you did not further have the time to maintain the plugin.
That's why I chose to use ISSO comments and so far I'm quite happy - also in regard to owning the date.
Thanks for the great work and superb communication 🙏🏼 .