Sebastian Gaiser

Results 97 comments of Sebastian Gaiser

@PaulRMellor thank you for reviewing the changes. I simply applied your suggestions. Please let me know if something is missing.

@pepov sorry to ping you but could you please mind have a look :D

@pepov @aditya7302 maybe my comment now is a bit controversial to remove the PrometheusRules completely or making the whole [Rules block configurable](https://github.com/kube-logging/logging-operator/blob/3c20c69c03f588a629b89e92f1b871ebb8e77038/pkg/resources/fluentbit/buffervolumeprometheusrules.go#L40).

@mcbenjemaa @simonpasquier can you please reopen the draft

That's a bug in ksm, see this PR https://github.com/kubernetes/kube-state-metrics/pull/2257

@RafalKorepta the problems are the same for every operator. (Good) examples at least for me are [kube-prometheus-stack](https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack) and [metallb](https://github.com/metallb/metallb/tree/main/charts/metallb). They ship the crds within the chart as "subchart". I think...

This may also solve https://github.com/kube-logging/logging-operator/issues/1923