Sebastian Feldmann comments

Results 111 comments of


Sebastian Feldmann

Relaunch editor if message is invalid or save to tempoarary file?

This can get very difficult if you are not using the command line to commit e.g. your IDE or other GUI tools. I'll have a look at the possibilities to...

Relaunch editor if message is invalid or save to tempoarary file?

@shochdoerfer this actually triggered some ideas, let's see what I can come up with. Thanks ;)

[Feature] Move working tree changes prior to running pre-commit hook

So the idea is to prevent `pre-commit` hooks to commit unwanted changes to the repository. That would mean that we had to configure an additional `pre-commit` hook that cleans up...

$STAGED_FILES is empty during ´git commit -a´ in Docker mode

Testing `unstaged` files would be a bad idea, because if the user is not committing the files why check them. You are right in local run mode the Cap'n detects...

$STAGED_FILES is empty during ´git commit -a´ in Docker mode

First up thanks for all your debugging and all the effort. I think before we discuss solutions we have to understand the error a bit better. So if I get...

$STAGED_FILES is empty during ´git commit -a´ in Docker mode

Maybe looking for a `GIT_INDEX_FILE` environment variable and adding it to the command would already solve the problem. ```php $cmd = 'GIT_INDEX_FILE=' . $envGitIndexFile . ' ' . $cmd; ```...

$STAGED_FILES is empty during ´git commit -a´ in Docker mode

Could you try to add some debug output that echos the `GIT_INDEX_FILE` environment variable?

$STAGED_FILES is empty during ´git commit -a´ in Docker mode

I'm not sure this is something that can be handled by the Cap'n Because of path mappings between the host and the container. There is no way for the Cap'n...

[feature] add a custom hint for failing actions

I would suggest something like this. ``` "actions": [ { "action": "tools/phpcs, "options": { "hint": ["my custom error message"], }, } ] ``` What do you think?

[feature] add a custom hint for failing actions

I thought a little bit about it and I think creating a dedicated CLI-Action is the way to go. Something like this ``` "actions": { { "action": "\\CaptainHook\\App\\Hook\\Cli\\Action\\Advanced", "options": {...