zipper icon indicating copy to clipboard operation
zipper copied to clipboard

Fork to use latest C++

Open sebastiandev opened this issue 7 years ago • 4 comments

Continuing discussion from #16 in order to decide effort to fix leaks and interface improvements

Yeah I rushed a little with C++17, but the main point was making a fork that would let us have a project that only deals with latest standard without having to worry with old compiler and odd platforms compatibility. Many of the issues we are seeing here are mostly because we decided not to use boost/qt as dependencies because of having compatibility in mind with other platforms.

My question is, is it worth it to work on a fix for the path management and memory leaks. Or maybe use that time to decide/improve the interface and have a state of the art up to date library?

sebastiandev avatar Sep 24 '17 20:09 sebastiandev

https://github.com/ctabin/libzippp can inspire you for your API, seems to me that your API can complete it.

I'm not fond of qt/boost and lib dependencies. But there is a lighter lib you can use: POCO https://pocoproject.org/documentation/index.html they have a Path class: https://pocoproject.org/slides/080-Files.pdf

Many of the issues we are seeing here are mostly because we decided not to use boost/qt

I don't think so, just missing delete in destructor for the moment.

Lecrapouille avatar Sep 25 '17 18:09 Lecrapouille

I will make an attempt to port this lib to C++17 using std::filesystem. If i have time i will also try to update the minzip dependency, we're using a 7+ year old version.

GiuseppeCesarano avatar Oct 18 '20 20:10 GiuseppeCesarano

@GiuseppeCesarano We can make a branch dev-c++17

Lecrapouille avatar Oct 19 '20 19:10 Lecrapouille

I think it's the best approach to make a separate branch

GiuseppeCesarano avatar Oct 20 '20 06:10 GiuseppeCesarano

An attempt was made https://github.com/sebastiandev/zipper/tree/dev-modernize I did not merge it inside the v2.x.y branch. I do not have energy and time to complete all libs with c++17 filesystem. Wait for pull requests :)

Lecrapouille avatar Sep 11 '22 01:09 Lecrapouille