Fixed #5230: @runClassInSeparateProcess has the same effect as @runTestsInSeparateProcesses

[WalterWoshid]

Did some refactoring and now it works :)

I also did some testing for my personal use case and it works!!!

[codecov[bot]]

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a6319b7) 89.80% compared to head (bdf2488) 81.34%.

:exclamation: Current head bdf2488 differs from pull request most recent head 546f158. Consider uploading reports for the commit 546f158 to get more accurate results

Files	Patch %	Lines
src/Util/PHP/AbstractPhpProcess.php	79.31%	6 Missing :warning:
src/Framework/TestSuite.php	94.73%	1 Missing :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##               10.5    #5233      +/-   ##
============================================
- Coverage     89.80%   81.34%   -8.47%     
+ Complexity     6420     5866     -554     
============================================
  Files           680      629      -51     
  Lines         20389    18564    -1825     
============================================
- Hits          18311    15100    -3211     
- Misses         2078     3464    +1386     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[WalterWoshid]

@ob_end_clean(); in the template sometimes logs failed to delete buffer. No buffer to delete to the console. Not sure what it's needed for, maybe someone can look into it and place it at the right position

[sebastianbergmann]

I am sorry that I was not able to review this pull request sooner. Can you please explain on a conceptual what was wrong and how you fixed it? Thanks!

This pull request has conflicts that must be resolved. It also targets the main branch. It should target the 10.5 branch now (it should have targetted the 10.1 branch when it was created).

[WalterWoshid]

Hi @sebastianbergmann,

as far as I remember, the logic for @runClassInSeparateProcess and @runTestsInSeparateProcesses was placed in the same loop for running tests which made it actually impossible to run the class in a separate process, which is why I moved the @runClassInSeparateProcess logic from TestCase to TestSuite. If you'd like, I can resolve the merge conflicts :)

[sebastianbergmann]

If you'd like, I can resolve the merge conflicts :)

Yes, please. Thanks!

[WalterWoshid]

Done :)

[WalterWoshid]

Sorry for the multiple actions, forgot the guidelines, then the type checking.

[sebastianbergmann]

Sorry for the multiple actions, forgot the guidelines, then the type checking.

No worries, I don't mind clicking that button ;)

[WalterWoshid]

No worries, I don't mind clicking that button ;)

Good, because I changed the wrong variable and didn't check the tests again x(

Should be good now 👌

[sebastianbergmann]

Can you have a look into why the tests fail on PHP 8.3 and PHP 8.4? Thanks!

[WalterWoshid]

Yes, I'll have a look at it :)

[sebastianbergmann]

Yes, I'll have a look at it :)

Any update on this? Thanks!

[sebastianbergmann]

Yes, I'll have a look at it :)

@WalterWoshid Any update on this? Thanks!

[staabm]

@WalterWoshid do you have plans to finish this PR?