phpunit icon indicating copy to clipboard operation
phpunit copied to clipboard

Allow TestSuite Specific Bootstraps

Open anubisthejackle opened this issue 3 years ago • 4 comments

This PR attempts to implement #3795

Tests have been created to verify that the configuration parses as expected, and that bootstraps are loaded both in a standard flow, as well as in process isolation.

anubisthejackle avatar Oct 30 '21 19:10 anubisthejackle

Codecov Report

Merging #4809 (8e86610) into master (cab3c1e) will decrease coverage by 0.68%. The diff coverage is 95.12%.

:exclamation: Current head 8e86610 differs from pull request most recent head 25426b6. Consider uploading reports for the commit 25426b6 to get more accurate results Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4809      +/-   ##
============================================
- Coverage     84.14%   83.45%   -0.69%     
+ Complexity     5774     5769       -5     
============================================
  Files           549      532      -17     
  Lines         16533    15446    -1087     
============================================
- Hits          13912    12891    -1021     
+ Misses         2621     2555      -66     
Impacted Files Coverage Δ
src/TextUI/Configuration/Xml/Loader.php 96.16% <88.88%> (-0.15%) :arrow_down:
src/Framework/TestSuite.php 89.16% <93.75%> (+0.34%) :arrow_up:
src/Framework/TestCase.php 84.15% <100.00%> (-3.30%) :arrow_down:
src/Framework/TestRunner.php 88.57% <100.00%> (+2.17%) :arrow_up:
...c/TextUI/Configuration/Xml/TestSuite/TestSuite.php 100.00% <100.00%> (ø)
src/TextUI/Configuration/Xml/TestSuiteMapper.php 80.95% <100.00%> (+0.95%) :arrow_up:
src/Event/Value/TestSuite/TestSuiteWithName.php 0.00% <0.00%> (-100.00%) :arrow_down:
src/Event/Value/Test/Phpt.php 33.33% <0.00%> (-33.34%) :arrow_down:
...rc/Event/Value/TestSuite/TestSuiteForTestClass.php 38.46% <0.00%> (-32.97%) :arrow_down:
src/Framework/MockObject/Rule/AnyParameters.php 50.00% <0.00%> (-16.67%) :arrow_down:
... and 430 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cab3c1e...25426b6. Read the comment docs.

codecov[bot] avatar Oct 31 '21 06:10 codecov[bot]

@sebastianbergmann Just checking in to see if there's anything that you'd like to do for this.

anubisthejackle avatar Nov 06 '21 21:11 anubisthejackle

@sebastianbergmann Just checking in to see if there's anything that you'd like to do for this.

Nothing right now except time to actually look into this. I want to finish the migration from TestListener and ResultPrinter to the new event system first before I look at other things, sorry.

sebastianbergmann avatar Nov 07 '21 05:11 sebastianbergmann

I want to finish the migration from TestListener and ResultPrinter to the new event system first before I look at other things, sorry.

Makes sense to me. I'm not in any rush.

anubisthejackle avatar Nov 07 '21 10:11 anubisthejackle

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

sebastianbergmann avatar Jan 13 '24 13:01 sebastianbergmann