phpunit icon indicating copy to clipboard operation
phpunit copied to clipboard

Fix JSON object order comparision with numeric keys

Open Firehed opened this issue 4 years ago • 2 comments

Fixes #4584, fixes #4674

Firehed avatar May 19 '21 22:05 Firehed

Codecov Report

Merging #4675 (aec46c1) into master (638c105) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4675   +/-   ##
=========================================
  Coverage     83.68%   83.68%           
- Complexity     4944     4945    +1     
=========================================
  Files           389      389           
  Lines         13126    13129    +3     
=========================================
+ Hits          10984    10987    +3     
  Misses         2142     2142           
Impacted Files Coverage Δ Complexity Δ
src/Util/Json.php 100.00% <100.00%> (ø) 10.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 638c105...aec46c1. Read the comment docs.

codecov[bot] avatar May 19 '21 22:05 codecov[bot]

I am sorry that it took me so long to review this. Can you please resolve the conflicts and target the 10.5 branch? Thanks!

sebastianbergmann avatar Jan 13 '24 14:01 sebastianbergmann