phpunit icon indicating copy to clipboard operation
phpunit copied to clipboard

Issue #4051: Added test for assertFileNotEqualsCanonicalizing

Open alecsmrekar opened this issue 4 years ago • 1 comments

Linked to issue: #4051

I first test if the method checks the existence of both the expected and actual files. I then test if the method correctly asserts that the files have different contents.

alecsmrekar avatar Apr 13 '21 12:04 alecsmrekar

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (67cfab0) 89.34% compared to head (c216f7e) 89.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4647      +/-   ##
============================================
+ Coverage     89.34%   89.37%   +0.03%     
  Complexity     6425     6425              
============================================
  Files           683      683              
  Lines         20405    20405              
============================================
+ Hits          18230    18237       +7     
+ Misses         2175     2168       -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 13 '21 12:04 codecov[bot]

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it: the test method you propose does too much.

sebastianbergmann avatar Jan 13 '24 13:01 sebastianbergmann