phpunit icon indicating copy to clipboard operation
phpunit copied to clipboard

Enhancement: Add error context on failing hook

Open ruudvanderweijde opened this issue 4 years ago • 2 comments

When a test fails because of a Throwable the error was not helping to locate the problem.

ruudvanderweijde avatar Jan 11 '21 20:01 ruudvanderweijde

Codecov Report

Merging #4579 (a02f78e) into master (d9655c8) will decrease coverage by 0.04%. The diff coverage is 100.00%.

:exclamation: Current head a02f78e differs from pull request most recent head 19ffe5e. Consider uploading reports for the commit 19ffe5e to get more accurate results Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4579      +/-   ##
============================================
- Coverage     83.57%   83.53%   -0.05%     
+ Complexity     5797     4553    -1244     
============================================
  Files           548      286     -262     
  Lines         15596    11760    -3836     
============================================
- Hits          13035     9824    -3211     
+ Misses         2561     1936     -625     
Impacted Files Coverage Δ
src/Framework/TestSuite.php 86.49% <100.00%> (-2.44%) :arrow_down:
src/Framework/TestStatus/Known.php 0.00% <0.00%> (-100.00%) :arrow_down:
src/TextUI/Exception/TestFileNotFoundException.php 0.00% <0.00%> (-100.00%) :arrow_down:
src/Framework/TestStatus/Failure.php 50.00% <0.00%> (-50.00%) :arrow_down:
src/Framework/SkippedTestCase.php 55.55% <0.00%> (-44.45%) :arrow_down:
src/Framework/IncompleteTestCase.php 55.55% <0.00%> (-44.45%) :arrow_down:
src/Framework/TestStatus/TestStatus.php 63.15% <0.00%> (-34.47%) :arrow_down:
src/Runner/Filter/Factory.php 75.00% <0.00%> (-25.00%) :arrow_down:
src/Framework/MockObject/Rule/InvokedCount.php 82.75% <0.00%> (-17.25%) :arrow_down:
src/Framework/TestStatus/Error.php 50.00% <0.00%> (-16.67%) :arrow_down:
... and 597 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9655c8...19ffe5e. Read the comment docs.

codecov[bot] avatar Jan 11 '21 20:01 codecov[bot]

@sebastianbergmann any thoughts on the suggested change?

ruudvanderweijde avatar Nov 25 '21 19:11 ruudvanderweijde

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

sebastianbergmann avatar Jan 13 '24 13:01 sebastianbergmann