Testdox improvements

[epdenouden]

• [x] implements #3567 ability to toggle buffering
• [ ] implements #3900 reduce data provider noise
• [x] improve unit test coverage in general
  • [x] Testdox buffering mechanism as seperate from colorization
  • [x] colorized Testdox features like the spinner
  • [x] more coverage Configuration value object
• [x] bunch of small fixes (typos, code style)

[codecov[bot]]

Codecov Report

Merging #4346 into master will increase coverage by 1.16%. The diff coverage is 95.27%.

@@             Coverage Diff              @@
##             master    #4346      +/-   ##
============================================
+ Coverage     85.28%   86.44%   +1.16%     
- Complexity     4610     4645      +35     
============================================
  Files           219      219              
  Lines         12164    11569     -595     
============================================
- Hits          10374    10001     -373     
+ Misses         1790     1568     -222     

Impacted Files	Coverage Δ	Complexity Δ
src/Util/Printer.php	51.51% <50.00%> (-4.37%)	15.00 <0.00> (+1.00)	:arrow_down:
src/Util/TestDox/CliTestDoxPrinter.php	96.96% <84.61%> (+2.80%)	60.00 <10.00> (+2.00)
src/Util/TestDox/TestDoxPrinter.php	95.90% <95.83%> (+17.03%)	82.00 <35.00> (+20.00)
src/Framework/DataProviderTestSuite.php	100.00% <100.00%> (ø)	4.00 <1.00> (+1.00)
src/Framework/TestSuite.php	82.16% <100.00%> (-0.41%)	129.00 <0.00> (+1.00)	:arrow_down:
src/TextUI/CliArguments/Builder.php	80.29% <100.00%> (+0.29%)	115.00 <0.00> (+2.00)
src/TextUI/CliArguments/Configuration.php	94.25% <100.00%> (+25.82%)	337.00 <88.00> (+4.00)
src/TextUI/CliArguments/Mapper.php	79.61% <100.00%> (+0.26%)	78.00 <0.00> (+1.00)
src/TextUI/DefaultResultPrinter.php	99.53% <100.00%> (+1.61%)	78.00 <0.00> (+2.00)
src/TextUI/TestRunner.php	64.15% <100.00%> (-0.03%)	222.00 <0.00> (ø)
... and 174 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 464a148...ab36ac8. Read the comment docs.

[Jellyfrog]

Maybe this could be splitted into multiple PRs to speed up time to market?

[nreynis]

Maybe this could be splitted into multiple PRs to speed up time to market?

Yes please, the disable-buffer is a crucial feature if you are doing continuous fullstack testing.
Without it testdox is really crippled : any test that goes wrong or make a job timeout and you go from having usable log to no log at all when you need them the most.

[sebastianbergmann]

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.