#4204: Show actual data in failed description for assertIsEmpty

[pwsdotru]

For issue https://github.com/sebastianbergmann/phpunit/issues/4204

[codecov[bot]]

Codecov Report

Merging #4209 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #4209   +/-   ##
=========================================
  Coverage     85.18%   85.18%           
  Complexity     4512     4512           
=========================================
  Files           243      243           
  Lines         12367    12368    +1     
=========================================
+ Hits          10535    10536    +1     
  Misses         1832     1832           

Impacted Files	Coverage Δ	Complexity Δ
src/Framework/Constraint/Cardinality/IsEmpty.php	100.00% <100.00%> (ø)	7.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43d0cca...20cb78f. Read the comment docs.

[sebastianbergmann]

~~Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it as I believe that #4204 should be addressed in the TeamCity logger instead.~~

[sebastianbergmann]

It might actually make sense to show the contents of an array when it is not empty but was used with assertIsEmpty(). I got confused there for a moment because I started looking at this from the TeamCity angle of #4204.

[sebastianbergmann]

This branch has conflicts that must be resolved.

[pwsdotru]

@sebastianbergmann Thank you for your review and comments. I fixed conflicts.

[sebastianbergmann]

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.