phpunit icon indicating copy to clipboard operation
phpunit copied to clipboard

#4049 Add tests for assertFileEqualsCanonicalizing

Open pwsdotru opened this issue 5 years ago • 2 comments

By issue #4049

pwsdotru avatar May 03 '20 13:05 pwsdotru

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (67cfab0) 89.34% compared to head (8ad163a) 89.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4203      +/-   ##
============================================
+ Coverage     89.34%   89.37%   +0.03%     
  Complexity     6425     6425              
============================================
  Files           683      683              
  Lines         20405    20405              
============================================
+ Hits          18230    18237       +7     
+ Misses         2175     2168       -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 03 '20 14:05 codecov[bot]

Test for compare canonicalizing string not worked, because comparator for files just compare strings - without canonicalizing

pwsdotru avatar May 03 '20 14:05 pwsdotru

Cherry-picked into 10.5, will merge to main from there. Thanks!

sebastianbergmann avatar Jan 13 '24 13:01 sebastianbergmann