phpunit-documentation-english icon indicating copy to clipboard operation
phpunit-documentation-english copied to clipboard

Published 20 hours ago • verified publisher icon sebastianbergmann

Update docs for expectException

Open Rowlando13 opened this issue 2 years ago • 1 comments

Add clarity for how expectException method should be called.

Rowlando13 avatar Sep 13 '22 22:09 Rowlando13

First PR for this project. Let me know what I need to fix.

Rowlando13 avatar Sep 13 '22 22:09 Rowlando13

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

sebastianbergmann avatar Feb 23 '23 06:02 sebastianbergmann

@sebastianbergmann You are very welcome. Is there any particular reason it did not get merged? I would like to know so that I can make better contributions in the future. My only though was that I was documenting something that was a bit obvious.

Rowlando13 avatar Mar 21 '23 21:03 Rowlando13

I rewrote large parts of the documentation while updating it for PHPUnit 10 and this PR was no longer applicable after that.

sebastianbergmann avatar Mar 22 '23 05:03 sebastianbergmann

@sebastianbergmann Thank you for clarifying!

Rowlando13 avatar Apr 21 '23 21:04 Rowlando13