comparator icon indicating copy to clipboard operation
comparator copied to clipboard

Add Comparator for Strings

Open pwsdotru opened this issue 4 years ago • 4 comments

Add one separate class for string compare

pwsdotru avatar May 14 '20 17:05 pwsdotru

Codecov Report

Merging #84 into master will decrease coverage by 0.62%. The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
- Coverage     99.30%   98.68%   -0.63%     
- Complexity      125      131       +6     
============================================
  Files            15       16       +1     
  Lines           288      304      +16     
============================================
+ Hits            286      300      +14     
- Misses            2        4       +2     
Impacted Files Coverage Δ Complexity Δ
src/StringComparator.php 89.47% <89.47%> (ø) 7.00 <7.00> (?)
src/Factory.php 95.00% <100.00%> (+0.12%) 15.00 <0.00> (ø)
src/ScalarComparator.php 100.00% <100.00%> (ø) 15.00 <0.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c46c67...16c6bb1. Read the comment docs.

codecov[bot] avatar May 14 '20 17:05 codecov[bot]

@sebastianbergmann can you please see this PR

I think it will good base for add canonicalize for string.

But need solve how calculate canonicalize.

pwsdotru avatar May 20 '20 17:05 pwsdotru

This branch has conflicts that must be resolved. Also, please explain what you want to achieve with this. So far, I do not see any benefit and am inclined to reject this pull request.

sebastianbergmann avatar Oct 19 '20 05:10 sebastianbergmann

@sebastianbergmann main idea was separtate comporator for scalar and string types. Because for string need make canonicalize comporators. Else need add condition like is_string and it code will not very clean

pwsdotru avatar Oct 21 '20 20:10 pwsdotru