Sebastian Bergmann comments

Results 557 comments of


                                            Sebastian Bergmann

Make `TestCase` methods `final` that should have been `final` all along

Would this help? #### WIP: Implement `TestCase::transformException()` hook method (`main` branch) ```patch diff --git a/src/Framework/TestCase.php b/src/Framework/TestCase.php index b875580d5..00898d070 100644 --- a/src/Framework/TestCase.php +++ b/src/Framework/TestCase.php @@ -671,7 +671,7 @@ final public function...

Make `TestCase` methods `final` that should have been `final` all along

> Previously we used `onNotSuccessfulTest` but it no longer exists in PHPUnit 10 and the reason why we need to override `runTest()` at the moment. `onNotSuccessfulTest()` still exists, but can...

Assert that arrays (or objects) are equal while excluding certain keys (or properties)

My suggestion would be to implement `Foo::equals()` and then use `assertObjectEquals()`.

Assert that arrays (or objects) are equal while excluding certain keys (or properties)

@lolli42 You are correct. I am still undecided whether or not I want to implement this or not.

Assert that arrays (or objects) are equal while excluding certain keys (or properties)

No, you "only" have the two options PHPUnit provides for this so far: registering a custom comparator or using `assertObjectEquals()` which in turn uses your value object's `equals()` or `equalTo()`...

Improve error message when `proc_open()` is disabled and a test is to be run in a separate process

Does this happen in both PHPUnit 9 and PHPUnit 10?

Improve error message when `proc_open()` is disabled and a test is to be run in a separate process

While I agree that this error (c|sh)ould be communicated better, I am reluctant to add `function_exists()` safeguards. IMO, using `disable_functions` in a development environment is an edge case that we...

`@runClassInSeparateProcess` has the same effect as `@runTestsInSeparateProcesses`

@ArturGoldyn IIRC, you were the original author of this functionality. May I bother you to have a look? Thanks!

`@runClassInSeparateProcess` has the same effect as `@runTestsInSeparateProcesses`

I fail to see how this could have ever worked and wonder whether it actually ever did. I will stop looking into this issue now. I am open to review...

Test Failure with current PHP 8.3.0-dev

Identified the change in PHP 8.3 that causes this using `git bisect`: https://github.com/php/php-src/commit/f6c0c60ef63c1e528dd3bd945c8f22270bbe3837 (https://github.com/php/php-src/pull/11169) by @nielsdos.