Sebastian Bergmann comments

Results 385 comments of


                                            Sebastian Bergmann

DOMNodeComparator::nodeToText used C14N but don't do anything when it fail.

CC @theseer

DOMNodeComparator::nodeToText used C14N but don't do anything when it fail.

> Since I'd recommend clearing the libxml error stack before we operate on the XML, PHPUnit calls `libxml_clear_errors()` after each test.

Canonicalizing array comparator leaks notices

I am not sure there is anything that I can do here apart from suppressing the notice. `sort()` simply should not be used on arrays that contain objects.

XML encoding is lost on canonicalization

Correct me if I am wrong, but canonicalization, and therefore the call to `DOMNode::C14N()`, is optional. If it is "bad" for you then do not enable it.

XML encoding is lost on canonicalization

Can you please send a pull request with your fix? Thanks!

Add ODBC support for DbUnit

I don't know. I never really looked at the implementation of DbUnit, sorry.

Ini setting with special chars breaks parsing

Can you send a pull request with a fix? Thanks!

Add max nesting level configuration option

How do you envision configuring this setting from PHPUnit?

Fix exception when types are not coherent

I would like to understand why it is `float` instead of `int` before (possibly) hiding any underlying root cause.

Blacklisting of object details for some classes/interfaces

I would, of course, accept a pull request that implements this in a generic way.