Sebastian Peter
Sebastian Peter
At some places in the code and ScalaDoc, "wall clock time" is used where "simulation time" is meant. For an explanation, one can consult the source below (or many other...
WeatherSource: - `WeatherSource#apply` and `WeatherSource#checkConfig` can be consolidated. `checkConfig` is a bad name considering what the method is doing, anyway. - Creation of `WeatherSourceWrapper` in line 344ff can be simplified...
Convert all groovy tests to ScalaTest, then remove everything related to groovy: - dependencies (spock, ...) - compile steps, if applicable - code formatting (spotlessGroovy) - ...
Bug might be fixed: https://github.com/diffplug/spotless/issues/1860 In detail, the changes of this commit can be reverted: https://github.com/ie3-institute/simona/commit/af8fba106a6dae7d17c8e69d35253319ed7c5920
Current draft for our future policy: No interface changes in patch versions No method deprecations, interfaces can change in major and minor versions Describe in readthedocs, developers guide @t-ober @danielfeismann
It is quite annoying that imports have to be sorted "manually", since different import orders can be committed and make merge conflicts more likely. Luckily, there are tools that can...
With #652, the messages sent and received by the scheduler changed. There's lots of `*.puml` diagrams and possibly documentation that needs to be adapted here: - `ActivityStartTrigger` is now called...
The GridAgent creates all ParticipantAgents that are connect to the corresponding subgrid. Once created, the GA also _watches_ the corresponding actors, meaning that it receives a `Terminated` message. *This message...
I'm not 100% sure if we need this, but: One should be able to configure CSV separators for outputs to be different from the separators for inputs. Let's say we're...
When no weather data is present for a coordinate/time combination, specific values (e.g. 0°K for empty temperature) are provided. https://github.com/ie3-institute/simona/blob/ad824fc592b772236782c9b44d1d79af2b494d14/src/main/scala/edu/ie3/simona/service/weather/WeatherSource.scala#L513-L518 We should have a discussion on whether this is the...