bamboo-api icon indicating copy to clipboard operation
bamboo-api copied to clipboard

installing package using npm doesn't include buildPlan method

Open Reuvenc opened this issue 8 years ago • 7 comments

Hi,

The bug described in the title occurred on version 0.0.5.

Thanks in advance, Reuven

Reuvenc avatar Mar 20 '16 16:03 Reuvenc

PR merged

sebarmeli avatar Mar 21 '16 00:03 sebarmeli

That's great, thanks!

Still, the problem occurs, the last method in /lib/bamboo is getAllPlans. Maybe increasing the version might help?

Reuvenc avatar Mar 21 '16 08:03 Reuvenc

@sebarmeli Please let me know if it's possible to publish the newer version soon.

Thanks in adavance, Reuven

Reuvenc avatar Mar 21 '16 17:03 Reuvenc

Hey, @Reuvenc , I just reviewing the code and method buildPlan never worked, there an error in the code and also no tests.

I will fix it and create PR, then @sebarmeli can review it.

pvoznenko avatar May 08 '16 12:05 pvoznenko

@Reuvenc created PR https://github.com/sebarmeli/bamboo-api/pull/16 , fixed buildPlan method.

pvoznenko avatar May 08 '16 16:05 pvoznenko

@pvoznenko Thanks for your fix.

Reuvenc avatar May 09 '16 15:05 Reuvenc

@Reuvenc , try to get 0.0.7 version , buildPlan should be there. @sebarmeli published update.

pvoznenko avatar May 10 '16 14:05 pvoznenko