backend
backend copied to clipboard
[BUG] Inconsistency when making/editing bookings as a (Super/Org)Admin
When making a new Booking (or editing an existing one via Admin-UI) via the normal Booking-UI, an Admin is informed, just like other users, that a Booking's Begin-Time may not be in the past. Issue is: for Admins, the Start-Time in the past is actually accepted/saved (which is good IMHO, but accordingly, the error/warning shouldn't be shown, to them. Additionally, this leads to issues in the Booking-UI, if there is a booking that ended before "now", but not before the entered start time of the attempted booking (There's an "Unknown Error" showing up, so, no permanent damage is done by creating concurrent bookings, but still, the shown error could probably be improved to something like "there's already a booking during at least a part of the attempted booking timeframe" or something?)
Steps to reproduce:
- open Booking UI, and, while being logged into an Admin Account, attempt to book a Space starting "an hour ago" until some time in the future (or even completely in the past.
- see the automatic warning(s) pop up for each Timestamp that is in the past
- still, press Enter/Save
Actual Result: Warnings are shown, but Booking is still saved (unless there is a conflicting booking for (part of) the timeframe) successfully, contrary to the shown warnings. Expected Result: No warnings shown for Admins, unless there's a conflicting booking(s) for the space in question.
P.S: Related to this, could there be a VIEW for non-admins(!) showing what the space occupancy situation is like, "right now" (via "book a space", I can only see the situation starting from the next :00 or :30 (depending on current time), but can't see bookings that will END at that time, already (because, internally, those end at :59 / :29, internally) (Usecase for this, in our org would be, among other things, for Emergency Evacuation helpers to be quickly able to see who is RIGHT NOW "supposed to be" in the office, and use that list to cross check against those employees savely evacuated, and thereby find out for whom the fire brigade should be sent to look for cause they aren't present at the muster/meeting point)