react-infinite icon indicating copy to clipboard operation
react-infinite copied to clipboard

Published 20 hours ago • verified publisher icon seatgeek

Move `enzyme-adapter-react-16` to devDeps

Open Kerumen opened this issue 7 years ago • 8 comments

enzyme-adapter-react-16 is only required for the tests, it shouldn't be included in the dependencies.

Kerumen avatar Apr 09 '18 13:04 Kerumen

Coverage Status

Coverage remained the same at 90.741% when pulling 15f1edf6da2c343694583fd5146615e0b1bad7b4 on Kerumen:master into d4517c975b73629d647516071e0415af61ac4231 on seatgeek:master.

coveralls avatar Apr 09 '18 13:04 coveralls

LGTM

danalloway avatar May 11 '18 14:05 danalloway

@Kerumen thanks for the PR! Do you know why there were so many changes in package-lock.json? It should only contain { "dev": true } changes

chrisvoll avatar Jul 23 '18 21:07 chrisvoll

@chrisvoll I don't know, I just moved the package and ran npm i.

Maybe npm changed his way to manage lock files since it has been generated. I have npm v6.2.0.

Kerumen avatar Jul 24 '18 12:07 Kerumen

hi @kgregory , why don't you merge this PR? please merge it and publish a new version.

geminiyellow avatar Sep 19 '18 05:09 geminiyellow

@geminiyellow I am not a maintainer

kgregory avatar Sep 19 '18 16:09 kgregory

opps, sorry @kgregory , you review and approve the PR, so think you are maintainer. and this library last merge is half year ago. is it still alive ? @garetht

geminiyellow avatar Sep 21 '18 01:09 geminiyellow

@geminiyellow I used this library in the past and was hopeful that it would be updated for React 16, but it doesn’t look good. I reviewed some issues and PRs to help out, but it doesn’t appear to have much support. Prove me wrong @garetht!

kgregory avatar Sep 21 '18 07:09 kgregory