nomad-firehose icon indicating copy to clipboard operation
nomad-firehose copied to clipboard

Published 20 hours ago • verified publisher icon seatgeek

Write kafka key to partition

Open ckong316 opened this issue 6 years ago • 3 comments

Modifies structs to take in a string 'key' (in addition to the data []byte) so the commands (allocation/jobs/nodes) can write the IDs to the key for kafka absolute order partitioning.

should have no effect on other sinks, as the key argument is ignored in the Put().

tested locally.

ckong316 avatar Nov 26 '18 22:11 ckong316

addressed some comments

ckong316 avatar Nov 30 '18 17:11 ckong316

LGTM

wyattanderson avatar Dec 06 '18 22:12 wyattanderson

Having this code merged would be a godsend. Are there any reasons not to merge this PR?

rostow avatar Feb 27 '23 10:02 rostow