nomad-firehose icon indicating copy to clipboard operation
nomad-firehose copied to clipboard

use sink name and command name for consule lock key

Open amfern opened this issue 6 years ago • 8 comments

amfern avatar Nov 06 '18 18:11 amfern

Why this change?

josegonzalez avatar Nov 17 '18 04:11 josegonzalez

I wanted to have different mixes of sinks for the same command, for example writing job changes to http and to mongo at the same time

amfern avatar Nov 18 '18 18:11 amfern

@jippi I'll leave merging/releasing to you :)

josegonzalez avatar Nov 19 '18 07:11 josegonzalez

I do realize its a breaking change, but it think its a needed one

amfern avatar Nov 19 '18 08:11 amfern

@amfern can you make it so it defaults to the current value, but you can override it by LOCK_NAME env variable?

jippi avatar Nov 19 '18 08:11 jippi

yes

amfern avatar Nov 19 '18 08:11 amfern

@jippi update the PR

amfern avatar Nov 19 '18 12:11 amfern

Hi, this now has a merge conflict :)

jippi avatar May 07 '19 10:05 jippi