jrule icon indicating copy to clipboard operation
jrule copied to clipboard

MDC tags not working anymore

Open querdenker2k opened this issue 11 months ago • 7 comments

No MDC tagging is possible anymore. I think it's broken with the dynamic rule stuff?

querdenker2k avatar Mar 18 '24 19:03 querdenker2k

Not sure, unfortunately I'm not using MDC tags atm. Probably something we should fix before next release.

seaside1 avatar Mar 20 '24 16:03 seaside1

I'll see if I can set it up again and test.

seaside1 avatar Mar 20 '24 16:03 seaside1

@rsopp Can you help to check this? I can't see anything apparent in the dynamic build PR, to me the MDC-tags looks similar as before

seaside1 avatar Mar 20 '24 19:03 seaside1

Adding @JRuleTag(value = "TESTTAG") On a testrule, and adding

    JRuleLog.debug(logger, context.getLogName(), "setting mdc tags: {}", context.getLoggingTags());
            Arrays.stream(context.getLoggingTags()).forEach(tag -> logInfo("mdc: using tag in context: {}", tag));

The tag seem to be stick when executing the rule: 2024-03-20 20:40:27.985 [INFO ] [on.jrule.internal.engine.JRuleEngine] - [JRuleEngine] mdc: using tag in context: TESTTAG

I'm in the process of setting up Graylog, so not using kibana/logstash atm. Maybe you can confirm between what commits the errors occurs @querdenker2k

seaside1 avatar Mar 20 '24 19:03 seaside1

no sorry, it's not all MDC tags. just the rule mdc tag is missing.

querdenker2k avatar Mar 20 '24 20:03 querdenker2k

haven't looked properly on monday. created a MR for the fix.

querdenker2k avatar Mar 20 '24 20:03 querdenker2k

haven't looked properly on monday. created a MR for the fix.

Thanks for fixing. Seems I have overseen this..

rsopp avatar Mar 20 '24 22:03 rsopp

Can this issue be closed?

seime avatar Jul 10 '24 10:07 seime

Yes, please

Am 10. Juli 2024 12:47:46 schrieb Arne Seime @.***>:

Can this issue be closed? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

querdenker2k avatar Jul 10 '24 13:07 querdenker2k