mark-my-search icon indicating copy to clipboard operation
mark-my-search copied to clipboard

[Feature Request] Highlight intensity

Open vatterspun opened this issue 2 years ago • 6 comments

The program is coming along really well and is way above what I expected. You've already included Regex and Whole Words checks. Just amazing ...

I say that both as a compliment and as a setup for the next issue because something that I'm running into is how the add-on is oddly a victim of it's own success.

CURRENT BEHAVIOR

When I do a search with 6+ keywords that are more basic words, it'll essentially flag the whole page. And now that I'm using the program almost all the time, highlighting the entire page has sort of the of just making it a pastel monster. It makes it hard to read and the best option is to manually zap keyword highlights until I get down to the main bits.

I can add some screenshots of recent searches that I'm doing if needed.

REQUESTED BEHAVIOR

If there's a way to make the results either A) less intense or B) turn up the transparency, that would be ideal. I wouldn't want to make the term listing up at the top any more transparent, just the words it's highlighting in page. So there's just a soft highlight for the key terms.


Hope that's an interesting suggestion, thanks for your work on this. More to come

vatterspun avatar Nov 22 '22 14:11 vatterspun

Thank you for the continued interest and suggestions, it's great to know the work is appreciated!

I will say that I have been concerned about bloat recently, mainly since I have been a bit enthusiastic about adding new features. I think it's OK at the moment, but I'm being more cautious now and too much power can be a bad thing of course. That said, I like this idea - I'm always for more personalisation, and this would definitely be useful.

Here are some of my thoughts:

  • Highlight colours were optimised to work for dark- and light-themes without having to detect the theme and adapt.
  • Side effect: they can be too transparent on white backgrounds and too bright on dark; also, can be overwhelming when many are highlighted.

Possible solutions:

  • Toggle button/shortcut to make highlights dimmer
    • User knows best when brighter/dimmer is better.
    • Steeper learning curve, pages with light and dark backgrounds do not work well.
  • Global setting to make highlights dimmer
    • Good for users with specific visual impairments or who use MMS for complex research.
    • Many users will never find the setting, only optimised for a single use case at once.
  • Make highlights dimmer when there are many keywords
    • No interaction required (automatic).
    • May confuse users, works poorly for large numbers of sparse keywords.
  • Make highlights dimmer where they appear in groups
    • Expands on an existing MMS feature ('blocks' of text are interpreted as a single flow), automatic, completely removes problem in most cases.
    • Maybe not actually what you want?

ator-dev avatar Nov 22 '22 14:11 ator-dev

By the way, I'm not sure if you know this, but there are other possible workflows in Mark My Search. You can hide/show highlights without removing them using Alt+Shift+D, and you can set hidden to be the default:

image

image

With highlights hidden, there are still two built-in tools to let you find matches:

  • The scroll markers beside the scrollbar show where groups of highlights occur.
  • Pressing a keyword in the toolbar focuses its next occurrence in the page, starting from the last place you clicked/selected. [Alt+Shift+1..9,0] does the same thing for individual keywords, and using Ctrl instead of Alt takes you to the previous one. Alt+Space / Alt+Shift+Space is again the same but for any keyword.

You can use these instead of looking for highlights manually. When 'jumping' using the buttons, highlights are temporarily shown for the group which was focused.

ator-dev avatar Nov 22 '22 15:11 ator-dev

Oof, yeah your possible solutions are a spot-on analysis of possible paths and problems around each choice. Very impressive.

I personally want to have have something in the interface that would let me modify things on the fly. Something like this:

image

But I can see why that wouldn't be ideal for the average user and might clog the interface. We've already got a lot of buttons and browser add-ons with tons of buttons generally get a cold response.

I guess the best course of action is therefore the second option of a Global Setting, but you're right that few will ever see it. That likely makes this a low priority enhancement.

vatterspun avatar Dec 11 '22 23:12 vatterspun

By the way, I'm not sure if you know this, but there are other possible workflows in Mark My Search.

No I had no idea. Again, very impressive. Thank you.

vatterspun avatar Dec 11 '22 23:12 vatterspun

I personally want to have have something in the interface that would let me modify things on the fly

Makes sense, it would definitely fit in - I would probably put it on the left next to highlight visibility (maybe it could be one button which hides highlights when you dim them twice..?).

All buttons can be toggled in the settings, and this would be a default-off (like the globe [search] now is) - I think you're right it might clog the interface, and I'll experiment of course when I get round to it.

Button settings as of 1.10: image

ator-dev avatar Dec 12 '22 00:12 ator-dev

Current plan as partially outlined in this issue:

Toolbar

  • Contrast button
    • Left click to set intensity higher (1 band)
    • Right click to set intensity lower (1 band)
    • Pull down to show intensity bands, release pointer to select currently hovered

Options

  • Contrast button
    • Show contrast button, default off
    • Swap left/right mouse clicks on button
    • List of intensity bands in numeric form, e.g. "10,14,16"
  • Default intensity band, e.g. 0
  • Add large border to highlights (layout-disrupting, only compatible with CLASSIC highlighter)

Note that while this is going to be a lot of additional complexity, I'll try to keep it as isolated as possible. I would consign this to an 'plug-in' add-on for MMS, but seeing as it's an accessibility issue I'm bumping it temporarily to mainline extension work.

In the future there will probably be a 'toolbar options for MMS' plug-in; when this is achieved, one of the first control/options combos to be transferred in will be this contrast button. There will be a significant migration period wherein users are given plenty of time to install this plug-in and set it up to their needs, which will be halted if user feedback is negative.

ator-dev avatar Mar 09 '23 15:03 ator-dev