Sean Hagstrom

Results 58 comments of Sean Hagstrom

Hey @chaitanyaprem 👋 I've re-run the tests with latest changes, and I think I'm still running into the issue, but it seems more difficult to reproduce. * In this case,...

Hey @chaitanyaprem I've re-run the tests with latest changes, and this time the issue was still reproducible but still tricky to encounter. ### Overview * In this case, I needed...

Closing this issue now that #20806 has been closed

### Commentary * The command for toggling selected git-diff hunks as some complex behaviours depending on the position of the cursor, and whether there are multiple git-hunks near each other...

#### Here's a screen recording of the current behaviour with the changes in this PR: https://github.com/user-attachments/assets/49abe418-cb21-4740-bd8a-a6798fbec50a

@ilmotta yeah good points about helping the user understand that data recovery is not perfect. @xAlisher do you have any thoughts on this?

Oki doki 🧑‍🌾 I've updated the verbiage with the latest proposal in this PR, here's how it looks:

@churik is it alright if we skip manual QA? I pre-emptively marked this as skippable, since it seemed like a small UI change, but what do you think?