reqwest icon indicating copy to clipboard operation
reqwest copied to clipboard

Refactor cookie store handling into a middleware

Open seanmonstar opened this issue 7 months ago • 4 comments

There's some code duplication for storing cookies internally, it would be good to clean it up into a single place as a service middleware that both the hyper client and the h3 client can share.

seanmonstar avatar May 27 '25 16:05 seanmonstar

I noticed that a h3 client takes a cookie_store when calling new(),default async client creates a Jar as a cookie_store,do you mean extracting those lines to a function or adding a completely new struct to perform both "store" and "manage" for all cookies from all urls? @seanmonstar

Lori-Shu avatar May 28 '25 09:05 Lori-Shu

I noticed that a h3 client takes a cookie_store when calling new(),default async client creates a Jar as a cookie_store,do you mean extracting those lines to a function or adding a completely new struct to perform both "store" and "manage" for all cookies from all urls? @seanmonstar

my solution to the latter #2701

Lori-Shu avatar May 28 '25 16:05 Lori-Shu

can i work on this??

edilson258 avatar Jun 03 '25 22:06 edilson258

can i work on this??

Hmm, I had some ideas to address this, thanks you @Lori-Shu @0x676e67 for your previous work.

linyihai avatar Aug 07 '25 06:08 linyihai