reqwest icon indicating copy to clipboard operation
reqwest copied to clipboard

reqwest 0.12.x incompatible with 0.11.x

Open zuisong opened this issue 1 year ago • 1 comments

During the process of upgrading xh to reqwest 0.12, I found two places that are incompatible with 0.11.x.

I wonder if this is a problem or a feature?

  1. works ok at 0.11.x and raise a error at 0.12.1

    reqwest = { version = "~0.12.1", features = ["rustls-tls", "native-tls", "native-tls-alpn"] }
    tokio = { version = "1.36.0", features = ["full"] }
    hyper = { version = "1.2.0", features = ["server"] }
    hyper-util = { version = "0.1.3", features = ["server"] }
    http-body-util = "0.1.1"
    
    #[tokio::main]
    async fn main() {
        let url = "https://github.com/";
    
        let resp = reqwest::Client::builder()
            .use_native_tls()
            .build()
            .unwrap()
            .get(url)
            .send()
            .await
            .unwrap();
        println!("{:?}", resp.status());
    	// it works ok at 0.11.x
    	// raise a error at 0.12.1
    }
    
  2. raise a error at 0.11.x and works at 0.12.1

    reqwest = { version = "~0.12.1", features = ["rustls-tls", "native-tls", "native-tls-alpn"] }
    tokio = { version = "1.36.0", features = ["full"] }
    hyper = { version = "1.2.0", features = ["server"] }
    hyper-util = { version = "0.1.3", features = ["server"] }
    http-body-util = "0.1.1"
    
    use reqwest::tls::Version;
    
    #[tokio::main]
    async fn main() {
        let url = "https://tls-v1-2.badssl.com:1012/";
    
        let resp = reqwest::Client::builder()
            .use_rustls_tls()
            .max_tls_version(Version::TLS_1_3)
            .min_tls_version(Version::TLS_1_3)
            .build()
            .unwrap()
            .get(url)
            .send()
            .await
            .unwrap();
        println!("{:?}", resp.status());
    }
    
    

zuisong avatar Mar 22 '24 17:03 zuisong

What specifically is the error that happens?

seanmonstar avatar Mar 22 '24 19:03 seanmonstar

I check and confirm that the first one has been already fixed by #2165.

cxw620 avatar Mar 23 '24 06:03 cxw620