reqwest icon indicating copy to clipboard operation
reqwest copied to clipboard

Add zstd support

Open paolobarbolini opened this issue 3 years ago • 10 comments

~~Opening as draft as I haven't tested it yet or haven't written any tests yet, but I'd be too interested in zstd support.~~

Closes #1463

~~EDIT: :disappointed: rustfmt stopped working again. I'll fix it when I'll submit tests~~

paolobarbolini avatar Feb 08 '22 14:02 paolobarbolini

:roll_eyes: Windows https://github.com/facebook/zstd/pull/3061#issuecomment-1034196613

paolobarbolini avatar Feb 11 '22 11:02 paolobarbolini

It seems like something has been broken with DNS for the entire day :thinking:

paolobarbolini avatar Apr 01 '22 14:04 paolobarbolini

Should I disable testing zstd on Windows so that we can get this merged? It doesn't look like there's been any progress on the zstd side, and I don't have a Windows machine to debug the issue

paolobarbolini avatar Apr 22 '22 10:04 paolobarbolini

Is zstd supposed to work on Windows? Is it a non-goal? Or they haven't been able to spend resources fixing it?

seanmonstar avatar Apr 22 '22 15:04 seanmonstar

It is supposed to work on Windows but I have no idea why it's not :sweat_smile:. Maybe https://github.com/Nemo157/async-compression/pull/144 will fix it.

paolobarbolini avatar Apr 23 '22 19:04 paolobarbolini

I got it to work now @seanmonstar

paolobarbolini avatar May 08 '22 08:05 paolobarbolini

indexmap bumped MSRV to 1.56

paolobarbolini avatar Jul 13 '22 06:07 paolobarbolini

Will the sync client also be getting this support?

TheDan64 avatar Aug 19 '22 19:08 TheDan64

Will the sync client also be getting this support?

It will. Now that I look at it I might have forgotten to add the option to disable it for it :sweat_smile:

paolobarbolini avatar Aug 19 '22 19:08 paolobarbolini

Awesome, thanks!

TheDan64 avatar Aug 19 '22 21:08 TheDan64