reqwest icon indicating copy to clipboard operation
reqwest copied to clipboard

Response bytes stream for WASM

Open SionoiS opened this issue 4 years ago • 4 comments

Hello!

Please advise. I'm not sure about returning an Option<Stream>, would it be fine to just unwrap and not return an option?

Also, I hope that adding this under the 'stream' feature was the right choice.

BTW this is the same as #1151

SionoiS avatar Oct 27 '21 15:10 SionoiS

Please advise. I'm not sure about returning an Option, would it be fine to just unwrap and not return an option?

I don't think we'd want a different API from the non-wasm one. I'm not an official reviewer though

paolobarbolini avatar Oct 27 '21 16:10 paolobarbolini

I don't think we'd want a different API from the non-wasm one.

True, we want the API to be the same regardless of target.

seanmonstar avatar Oct 27 '21 16:10 seanmonstar

It now return a stream like other APIs.

SionoiS avatar Oct 28 '21 13:10 SionoiS

Deps have been streamlined (I think...)

SionoiS avatar Nov 01 '21 15:11 SionoiS