pretty-env-logger icon indicating copy to clipboard operation
pretty-env-logger copied to clipboard

add (enabled by default) regex feature and update env-logger to 0.8

Open jakobhellermann opened this issue 5 years ago • 6 comments

see #28. I don't think disabling color is that useful because at that point you can just use env_logger directly, so I just added a feature for regex.

jakobhellermann avatar May 19 '20 17:05 jakobhellermann

This needs to be updated to 0.8, but besides that is there anything that could move it forward, @seanmonstar?

lnicola avatar Oct 20 '20 19:10 lnicola

done :+1:

jakobhellermann avatar Oct 20 '20 19:10 jakobhellermann

@seanmonstar can this PR or #42 be looked into? I want to use pretty-env-logger in a project but pulling in the entire regex crate is a big no-no.

holly-hacker avatar Jan 23 '21 17:01 holly-hacker

I'm also finding the regex crate dependency to be challenging. I swallowed the bullet but it increases my binary size by 30%.

There's another variation of this PR by myself at #42. Anything that I could do to help make it happen?

I know it's not much, but I subscribed as a GH sponsor to show some appreciation for hyper, warp, reqwest and many of your other projects that I'm using extensively. Thank you :)

shesek avatar Mar 24 '21 15:03 shesek

TBH, I think the crate is small enough that you can fork/vendor and modify/make a new one based on it.

lnicola avatar Mar 27 '21 07:03 lnicola

@seanmonstar can this be merged?

ibraheemdev avatar May 18 '21 14:05 ibraheemdev