Sean McBride

Replaced old atoi() with better strtol()

4

atoi() gives no opportunity for error checking, strtol() does. Though I did not actually improve error checking...

Bounded flexible arrays: tag their element count

10

I took a stab at preparing for gcc/clang adding support for bounds checking of flexible arrays, see: https://people.kernel.org/kees/bounded-flexible-arrays-in-c And I think I found a small buffer overread in the process...

Increased usbi_get_tid() from int to long

2

This function has different implementations on every OS, but for some, like macOS, it was truncating from 64 to 32 bit by casting to int. So increased its size from...

WIP: add clang thread safety annotations

2

See: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html

Documentation/Maintenance/Dashboard.md refers to a link that is 404

2

In `Documentation/Maintenance/Dashboard.md` there is the command: `$ git remote add -t dashboard origin https://itk.org/ITK.git` But that fails. Where has this moved? To github somewhere I guess?

Misc clang-tidy fixes, and added a .clang-tidy config file

2

This fixes some clang-tidy warnings. Some were fixed automatically by the tool. Some were fixed manually by me after the tool warned about them. I've added a clang-tidy config file...

linker error building on OpenBSD, need to pass `-lexecinfo`

8

Trying to build current master on OpenBSD: ``` [ 34%] Linking C executable ncrandom cd /home/builder/external/netcdf-bin/libdispatch && /usr/local/bin/cmake -E cmake_link_script CMakeFiles/ncrandom.dir/link.txt --verbose=1 /usr/bin/cc -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -g CMakeFiles/ncrandom.dir/ncrandom.c.o -o ncrandom -Wl,-z,origin,-rpath,/home/builder/external/netcdf-bin/liblib:/usr/local/lib...

I've fixed as many -Wcast-qual warnings as I can, but there are about 9 left (see also https://github.com/OSGeo/PROJ/pull/3496). They need someone that knows the codebase well (not me). IMNSHO, C++...