Sean Linsley
Sean Linsley
It looks like `tokio_postgres::GenericClient` doesn't support `copy_in` so deadpool couldn't either. It seems like the function that relies on `copy_in` will have to accept a `&deadpool_postgres::Client` while others that could...
The problem is, I would like to DELETE from a table and then COPY in a transformed version of the data, all inside a transaction. It seems that `tokio_postgres::GenericClient` doesn't...
Actually it seems that tokio-postgres does support transactions through SQL-standard `BEGIN` / `COMMIT` / `ROLLBACK`, so that would mean I don't need to use `GenericClient`. Is there some reason to...
Thanks for the feedback @bikeshedder. I'll hold off on opening PRs until we hear from @sfackler, for now just recommending that the transaction is managed with a macro: https://github.com/pganalyze/pco_store/commit/cdb44c480ad8f76b81f4daf479e888ead60e42a2
Thanks for the PR @absporl, and your efforts as well @psteinroe. It would be interesting to compare the runtime performance of each approach (I'm less concerned about compile times), especially...
This seems reasonable, though I wonder if it needs to be a feature or should be unconditionally enabled. I wonder why CI is failing; the error seems to be unrelated...
I think it should be fine to enable it by default. Note that when making that update, the generated protobuf definitions are now stored in the repo as `src/protobuf.rs`. A...
Looks good, sorry for the delay reviewing.
According to https://www.ruby-lang.org/en/downloads/branches/ Ruby 3.0 and lower are no longer receiving updates, so we can probably stop supporting them.
> At least on blog pages, if not all pages. For consideration: http://ia.net/blog/sweep-the-sleaze/ http://ia.net/blog/sweep-the-sleaze-reactions/ http://solomon.io/why-im-done-with-social-media-buttons/