Sean M. Law
Sean M. Law
Thank you for your prompt response @mreineck! > As far as I know, scipy currently does use cached plans for pocketfft, and the size of the cache is 10, so...
@NimaSarajpoor Please allow me some time to review it
@NimaSarajpoor For completeness, are you able to provide some timings for the speedup (before and after your code changes) here in the comments? I trust that the code is indeed...
@NimaSarajpoor Can you tell me how you are computing "Speedup %"? The numbers don't look right to me. I think perhaps the wording should be "Percent Reduction" (i.e., `100 *...
@NimaSarajpoor Considering that all of the existing tests are passing and the performance is improved, I feel pretty good about merging this. Do you think it's ready? Was there anything...
> My first concern is whether the added test function is clear. My second concern is regarding the comment I added for case 2 in the test function Okay, I...
> My main point was to help future me remember why I used a particular approach for calculating P_ref and I_ref. Now that you mention it, I think it would...
@NimaSarajpoor I will take a look
@NimaSarajpoor Thanks again for the wonderful contribution!
@NimaSarajpoor I'm not too concerned with either of these warnings/errors Sure, we could add an extra run to the workflow to update `pip`. That's fine. As for the codecov, with...