Sean M. Law

Results 429 comments of Sean M. Law

> I figured out the issue - and I do believe this warrants an update to the 'Contributing Guide' and perhaps an update to 'test.sh'. I had cloned STUMPY locally...

> thank you very much for the direction here - it was super helpful! No, thank YOU! Sometimes, contributing (to Python packages) can be front loaded with frustrating issues like...

@NimaSarajpoor I just noticed that `scipy.fft.rfft` has a parameter called `workers`, which can perform FFT in parallel. I wonder if you could try that and see if it makes any...

@NimaSarajpoor I came across a more recent FFT implementation called [OTFFT](http://wwwa.pikara.ne.jp/okojisan/otfft-en/stockham2.html) that claims to be faster than FFTW and has a more generous MIT license. However, I tried to implement...

Thanks @NimaSarajpoor. In case it matters (and if you're not already doing this), it would make sense to test window sizes and/or time series lengths in powers of `2` rather...

> It turns out that x will be output if we just avoid dividing it by n. Hmmm, I wonder why they performed the division?! Thanks for figuring it out....

If I understand correctly, the stockham algorithm is NOT faster than `scipy.fft.convolve` (or they are about the same after some optimizations). Is that correct? And it also means that the...

It appears that maybe we should consider implementing the [six step or eight step FFT algorithm](http://wwwa.pikara.ne.jp/okojisan/otfft-en/sixstepfft.html) next as it should have much better memory locailty and is therefore "optimized". I'd...

> I have implemented six-step-FFT. I will work on eight-step FFT algorithm. In case it matters, [section 6.3](https://www.researchgate.net/profile/Christos-Bechlioulis/publication/341270520_FFT_algorithms_are_not_mine_However_I_am_going_to_convince_you_soon_regarding_the_visit_of_RMS_to_our_university_Believe_it_or_not_this_is_me_This_is_us_Univeristy_of_Patras_you_have_chosen_a_quite_wr/links/5fa53ce7299bf10f7328c33b/FFT-algorithms-are-not-mine-However-I-am-going-to-convince-you-soon-regarding-the-visit-of-RMS-to-our-university-Believe-it-or-not-this-is-me-This-is-us-Univeristy-of-Patras-you-have-chosen-a-quite.pdf) might be relevant as it discusses Stockham and the 6-step algo. More...

> should we expect the 6-step and 8-step implementation (without multithreading) be faster than the scipy.fft.fft ? Based on [these performance results](http://wwwa.pikara.ne.jp/okojisan/otfft-en/index.html) I expect the `njit` version of the 6/8...