Sean M. Law
Sean M. Law
@dylanjprice If it's okay with you, I would like to start the first round(s) of feedback focused around the generation of the "arbitrary range indices". While you incorporate those comments,...
> I can absolutely improve it to the library's standards if you don't mind taking time to provide the rounds of feedback. I am 100% here for this and I...
No worries. All good here! --- View entire conversation on ReviewNB
@dylanjprice I've left some initial comments for you to consider. Please take a look at your earliest convenience.
> Hey, I've been busy at home, going to take a look at this tomorrow though. Absolutely no rush on my end. I prefer quality over speed and I know...
Okay sounds good. Keep the trivial=True and AB-join functionality though, right?Yes, if you look at the code I posted, it should already handle the exclusion zones and AB-joins for you...
@dylanjprice Excellent questions. Please give me a little time to formulate a proper response to your points above. > wasn't sure if the inline comments should be resolved first If...
> Maybe this is a trivial question, but I wasn't sure what you have in mind with regard to taking out the first distance calculation, changing the output structure and...
From what (little) I can tell, it might be challenging to map the JIT compiled code back to the native Python code (which gets JIT decorated). Ultimately, my goal is...
@bfdykstra I don't know anything regarding the `matrixprofile` API but if you'd like to submit a PR to this repo with the `stumpy` replacement parts then I can help review...