sealer icon indicating copy to clipboard operation
sealer copied to clipboard

[proposal] propose new instructions in kubefile

Open justadogistaken opened this issue 2 years ago • 5 comments

Describe what this PR does / why we need it

related to [Proposal] A more k8s-based/rootfs-transparent instructions in Kubefile

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

For CNI/CSI/APP, I still fail to think throgh the dynamic render for remote fetching(https) files at runtime (this is easy to accomplish at local).

This is note a ultimate version, propose this to have a discussion with you guys. @sealerio/sealer-maintainers @sealerio/sealer-reviewers

justadogistaken avatar Jul 22 '22 03:07 justadogistaken

Codecov Report

Merging #1601 (cad6988) into main (25b39ce) will increase coverage by 2.22%. The diff coverage is n/a.

:exclamation: Current head cad6988 differs from pull request most recent head eae6b6c. Consider uploading reports for the commit eae6b6c to get more accurate results

@@            Coverage Diff             @@
##             main    #1601      +/-   ##
==========================================
+ Coverage   11.82%   14.04%   +2.22%     
==========================================
  Files          91       78      -13     
  Lines        8112     6691    -1421     
==========================================
- Hits          959      940      -19     
+ Misses       7030     5637    -1393     
+ Partials      123      114       -9     
Impacted Files Coverage Δ
pkg/cert/kube_certs.go
pkg/runtime/kubernetes/reset.go
pkg/runtime/kubernetes/kubeadm_runtime.go
pkg/runtime/kubernetes/kubeadm.go
pkg/runtime/kubernetes/upgrade.go
pkg/runtime/kubernetes/registry.go
pkg/runtime/kubernetes/init.go
pkg/cert/kubeconfig.go
pkg/runtime/kubernetes/runtime.go
pkg/runtime/kubernetes/update_cert.go
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jul 22 '22 03:07 codecov-commenter

@justadogistaken ,

Very excited to see our newly refactored kubefile instruction, I have some questions about the LAUNCH instruction and offline delivery.

  1. Different applications start in different ways, such as: helm package, yaml file application. Do we need to distinguish them by adding several parameters?
  2. Could we support building applications with variable parameters? such as the image name in yaml which can be specified at run stage, build once and run it according to different parameters.
  3. Some applications are started by the operator, after that the related pods are started. if cluster image is delivered to the offline environment, the images of those pods need to be saved in clusterimage in advance.

kakaZhou719 avatar Jul 22 '22 07:07 kakaZhou719

@kakaZhou719 Thanks for your suggestions.

  1. I agree with you, we will support options/flags to support various app installation.
  2. For this problem, how do we handle this at present? I guess it dues to env rending?(I' not so sure), and of course I can allow users to input some args at the LAUNCH.
  3. I'm confused with this problem. In this way, it won't affect image saving. What you mean is COPY imageList manifest? We won't remove the original instructions, and I can also provide a instruction to support that. And is this related to LAUNCH, I still feel confused. Maybe you can share more detailed information.

justadogistaken avatar Jul 22 '22 07:07 justadogistaken

I think it's hard to render yaml from remote fetching(http). Unless users have preprocessed those files. I recommend we support local files to build only at present?

justadogistaken avatar Jul 22 '22 08:07 justadogistaken

./docs/design/kubefile_alpha.md:7: MD009 Trailing spaces ./docs/design/kubefile_alpha.md:8: MD009 Trailing spaces ./docs/design/kubefile_alpha.md:9: MD009 Trailing spaces ./docs/design/kubefile_alpha.md:110: MD012 Multiple consecutive blank lines ./docs/design/kubefile_alpha.md:50: MD031 Fenced code blocks should be surrounded by blank lines ./docs/design/kubefile_alpha.md:56: MD031 Fenced code blocks should be surrounded by blank lines ./docs/design/kubefile_alpha.md:88: MD038 Spaces inside code span elements

allencloud avatar Jul 27 '22 02:07 allencloud

/test apply

justadogistaken avatar Aug 11 '22 15:08 justadogistaken

LGTM

allencloud avatar Aug 12 '22 02:08 allencloud