Vincent Zhang

Results 59 issues of Vincent Zhang

Think about this snippet ```elisp (use-package vertico-posframe :when (display-graphic-p)) ``` According to the current design, the snippet will expand to ```elisp (progn (use-package-ensure-elpa 'vertico-posframe '(t) 'nil) (when (display-graphic-p))) ``` But,...

For example: ```elisp (unbind-key ([remap xref-find-definitions]) go-mode-map) ``` Return errors: ```elisp Debugger entered--Lisp error: (invalid-function [remap xref-find-definitions]) ([remap xref-find-definitions]) (let* ((name ([remap xref-find-definitions])) (key (if (vectorp name) name (read-kbd-macro name)))...

bug
bind-key

Hi , Thanks for this great package! I am enjoying it. In Emacs 29, the native tree-sitter is introduced. Also some new major-modes are introduced, e.g. `python-ts-mode`, `c-ts-mode`, `go-ts-mode`, etc....

Hi , Thanks for this great package! I am enjoying it. In Emacs 29, the native tree-sitter is introduced. Also some new major-modes are introduced, e.g. `python-ts-mode`, `c-ts-mode`, `go-ts-mode`, etc....

In Emacs 28.1 on Ubuntu 20.04, I got these errors while installing the latest `dap-mode`. No errors are observed in 29.x. ```elisp Compiling file /home/vincent/.emacs.d/elpa/dap-mode-20230425.1859/dap-chrome.el at Wed Apr 26 10:15:47...

I got this error with the latest version on 29.1/Arch. ```elisp Debugger entered--Lisp error: (error "Invalid search bound (wrong side of point)") #("^\\([^:]*\\): \\(.+\\)" # t nil) ad-Advice-re-search-forward(# "^\\([^:]*\\): \\(.+\\)"...

awaiting

Can you please add an option `flycheck-posframe-parameters` for `:override-parameters` of `posframe-show`, like [ivy-posframe](https://github.com/tumashu/ivy-posframe) does? Thanks!

https://github.com/tumashu/posframe/blob/739d8fd1081bdd0d20dee9e437d64df58747b871/posframe.el#L301-L307 请教下,我看到这里判断arg是否被修改,如果修改过就会删除并重新创建子窗口。很多场景下会造成一定程度的闪烁,打开时(比如 ivy-posframe)会有一点延迟。有没有可能直接用`modify-frame-parameters` 来复用child frame呢?这样是否能提高性能? 最近我在看[mini-frame](https://github.com/muffinmad/emacs-mini-frame),发现在很多场景下性能会比posframe高些。mini-frame就是尽量复用已经创建的frame。不过,由于在Linux上表现不佳,我还是倾向于使用posframe,但是希望能改进性能。希望您能看看?很多细节我还不是很明白。谢谢! ```elisp (if (frame-live-p posframe--frame) ;; 复用现有frame (modify-frame-paremeters ...) ;;创建新frame (make-frame ...)) ```

https://github.com/yanghaoxie/transient-posframe/blob/dcd898d1d35183a7d4f2c8f0ebcb43b4f8e70ebe/transient-posframe.el#L123 See https://github.com/doomemacs/doomemacs/issues/2637#issuecomment-627187206 and https://github.com/yanghaoxie/which-key-posframe/issues/20.

https://github.com/yanghaoxie/which-key-posframe/blob/90e85d74899fc23d95798048cc0bbdb4bab9c1b7/which-key-posframe.el#L129 When `which-key--buffer` is nil, will get this error: ``` Debugger entered--Lisp error: (wrong-type-argument stringp nil) get-buffer(nil) posframe-delete-frame(nil) posframe-delete(nil) which-key-posframe-mode(toggle) funcall-interactively(which-key-posframe-mode toggle) call-interactively(which-key-posframe-mode record nil) #f(compiled-function (cmd &optional record-flag keys...