EasyPipes icon indicating copy to clipboard operation
EasyPipes copied to clipboard

KeepAlive required for encryption

Open nixtar opened this issue 1 year ago • 0 comments

Hello,

While testing out EasyPipes I discovered that when implementing encryption as per the readme that I could still see the secrets in plain text in a packet capture.

After digging into the code I discovered that if you don't explicitly call Connect() on the client KeepAlive is set to false and the IpcStream is disposed in the client if Connect is not used to prepopulate the Stream property.

This all makes sense, but it might be nice to call this out in the readme? I could see people implementing this as per the readme and not checking if it's actually encrypting.

A possible breaking change might be to just make it encrypt by default if an Encryptor is provided? What's the intent behind the EncryptIfTrue attribute?

nixtar avatar Sep 09 '24 03:09 nixtar