helm-compose icon indicating copy to clipboard operation
helm-compose copied to clipboard

feat: only upgrade helm on change

Open dberuben opened this issue 2 years ago • 3 comments

Did I miss something?

(☸|lspay-trial-eu-west-1:default)➜  helm-compose-test helm ls
NAME       	NAMESPACE	REVISION	UPDATED                              	STATUS  	CHART            	APP VERSION
helloworld1	default  	4       	2023-09-01 15:56:18.159761 +0200 CEST	deployed	hello-world-0.6.0
helloworld2	default  	4       	2023-09-01 15:56:18.115698 +0200 CEST	deployed	hello-world-0.6.0
(☸|lspay-trial-eu-west-1:default)➜  helm-compose-test helm plugin list
NAME   	VERSION	DESCRIPTION
compose	1.2.0
apiVersion: 1.1

storage:
  name: mycompose
  type: local # default
  path: .hcstate # default

releases:
  helloworld1:
    chart: sikalabs/hello-world 
    values:
      replicas: 2
  helloworld2:
    chart: sikalabs/hello-world 
    values:
      replicas: 2
repositories:
  sikalabs: https://helm.sikalabs.io

dberuben avatar Sep 01 '23 14:09 dberuben

Ok works for helm compose list

(☸|lspay-trial-eu-west-1:default)➜  helm-compose-test helm compose list
| Date             | Revision |
| ---------------- | -------- |
| 2023-09-01 16:03 |        1 |

I was hoping for helm ls be the same

dberuben avatar Sep 01 '23 14:09 dberuben

@dberuben this is default helm behaviour. Which I wouldn't like to mess with as you might never know if the referenced chart or value files have changed.

A release version is an incremental revision. Every time an install, upgrade, or rollback happens, the revision number is incremented by 1. The first revision number is always 1

https://helm.sh/docs/intro/using_helm/#:~:text=Every%20time

tuunit avatar Sep 01 '23 15:09 tuunit

I'll consider a feature flag to use helm-diff and only execute an upgrade if something truly changed but that shouldn't happen by default.

tuunit avatar Sep 01 '23 15:09 tuunit