Harald Heckmann comments

Results 68 comments of


                                            Harald Heckmann

[PM] Add the ability to flag invalid markets

We also have to define precisely and transparently and communicate which properties render a market as "invalid"

[Swaps] Add additional rpcs

Set on-hold for more urgent tasks.

Should a non-oracle reported stake ZTG?

I see your point and I agree. The reason why it is okay for now is that we still have the dispute mechanism. The question is what stake should we...

[PM] Use `twox_64_concat` hash function for `MarketIdsPer*`

since we use incrementing timeframes or block numbers, it can be the more lightweight but less secure `twox_64_concat`. However, the change requires a storage migration. The optimization is not needed...

`join_subsidy` and `exit_subsidy` interact incorrectly with pool after collection of subsidy

Good catch. It seems this can't be abused because it errors out (although for the wrong reason) when trying to remove subsidy from a pool after subsidy collecting state. I'll...

Reserve-Bonds in prediction markets when updating the const parameter_types!

Good catch Chris, this is a serious problem that we has to be handled. **case 1: We reduce the bonds** This is straightforward, a migration will unreserve the the difference....

[Relay] Upgrade Battery Station Rococo relay chain

Upgrade v0.9.14 -> v0.9.16 already happened. Should bump to v0.9.21 (at least) soon.

[market-commons] Remove `now()` method from `MarketCommonsPalletApi`

I think the idea Caio had when he created this was to avoid having another type in the `Config` trait of the `prediction-market` pallet, but rather using something we already...

[Feature Request] Add Lock and Unlock events to pallet balances

Sure, I'll prepare a PR soon.